Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update phrase "url" to "urls" and update error handling #421

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update phrase "url" to "urls" and update error handling #421

wants to merge 1 commit into from

Conversation

kiya956
Copy link
Contributor

@kiya956 kiya956 commented Nov 29, 2024

  1. Correct variable "url" to "urls" due to it's not single url but a list of url
  2. add logger to fail case

Description

  1. Correct variable "url" to "urls" due to it's not single url but a list of url
  2. add logger to fail case

Resolved issues

Documentation

Web service API changes

Tests

  1. test normal provision and urls successfully
  2. test wrong provision data and device-connector would return fail and error message
  3. test wrong urls and device connector would return fail and error message

@kiya956
1. Correct variable "url" to "urls" due to it's not single url
815750f 
   but a list of url
2. add logger to fail case

Signed-off-by: ChunAn Wu <[email protected]>
@kiya956 kiya956 requested a review from a team as a code owner November 29, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kiya956